Merged
Conversation
…creates an opaque Chromium origin that silently blocks file:// script loading (Plotly.js).
Owner
Author
|
refer to #377 |
Owner
Author
|
tests are failing because of missing WebKit but it is a different issue, so I'll go for the merging this PR. So other PR will be smaller and related to other topics. What do you think @bruno-portfolio? |
Contributor
|
Yeah, that works ! |
Owner
Author
|
thanks you so much for this fix, it was a nice collaboration! If you have other ideas or fixes to do just contact me! |
Contributor
|
If there's anything else I can help you with, please let know. I'm getting back to work tomorrow so I may take a while to respond but will do my best. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit that allows to use the plugin with both QGIS 3 and QGIS 4.
For sure there are more elegant ways to check the QGIS versions and load only what is needed, but QGIS 3 will become deprecated so I prefer to spend more time on QGIS 4.
Tested on QGIS 3.44 and QGIS 4 on my Debian machine:
@bruno-portfolio the layout stuff is still to migrate! Given that the whole file is very different because of all the js and WebKit vs WebEngine stuff, I'm not sure if the best way is to create 2 different files and then depending on the QGIS version we can import one or the other.